[PATCH] D55763: [Sparc] Add Sparc V8 support

[Daniel Cederman via Phabricator]

dcederman marked an inline comment as done.
dcederman added a comment.

Thanks for the review!



================
Comment at: src/DwarfParser.hpp:701
+
+      _LIBUNWIND_TRACE_DWARF("DW_CFA_window_save()\n");
+      break;
----------------
compnerd wrote:
> Could you put this before the execution of the op please?
Sure. But for the other ops the trace printout is placed after the op, so this would break that pattern?


================
Comment at: src/UnwindRegistersRestore.S:1023
+  jmp %o7
+   nop
+
----------------
compnerd wrote:
> Indentation is off
The extra space is a convention used when writing Sparc assembly to indicate that the instruction is in the delay slot of the previous instruction.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55763/new/

https://reviews.llvm.org/D55763