[libcxx] r350477 - Revert "D56064: More tolerance for flaky tests in libc++ on NetBSD"

Kamil Rytarowski n54 at gmx.com
Sat Jan 5 12:11:54 PST 2019


Author: kamil
Date: Sat Jan  5 12:11:54 2019
New Revision: 350477

URL: http://llvm.org/viewvc/llvm-project?rev=350477&view=rev
Log:
Revert "D56064: More tolerance for flaky tests in libc++ on NetBSD"

Requested by EricWF.

Modified:
    libcxx/trunk/utils/libcxx/test/format.py

Modified: libcxx/trunk/utils/libcxx/test/format.py
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/utils/libcxx/test/format.py?rev=350477&r1=350476&r2=350477&view=diff
==============================================================================
--- libcxx/trunk/utils/libcxx/test/format.py (original)
+++ libcxx/trunk/utils/libcxx/test/format.py Sat Jan  5 12:11:54 2019
@@ -12,7 +12,6 @@ import errno
 import os
 import time
 import random
-import platform
 
 import lit.Test        # pylint: disable=import-error
 import lit.TestRunner  # pylint: disable=import-error
@@ -203,12 +202,6 @@ class LibcxxTestFormat(object):
                           for f in os.listdir(local_cwd) if f.endswith('.dat')]
             is_flaky = self._get_parser('FLAKY_TEST.', parsers).getValue()
             max_retry = 3 if is_flaky else 1
-
-            # LIBC++ tests tend to be more flaky on NetBSD, so add more retries.
-            # We don't do this on other platforms because it's slower.
-            if platform.system() in ['NetBSD']:
-                max_retry = max_retry * 3
-
             for retry_count in range(max_retry):
                 cmd, out, err, rc = self.executor.run(exec_path, [exec_path],
                                                       local_cwd, data_files,




More information about the libcxx-commits mailing list