[libcxx-commits] [libcxx] r355006 - [libc++] Remove visibility-related warnings with Clang 8

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Wed Feb 27 09:33:26 PST 2019


Author: ldionne
Date: Wed Feb 27 09:33:25 2019
New Revision: 355006

URL: http://llvm.org/viewvc/llvm-project?rev=355006&view=rev
Log:
[libc++] Remove visibility-related warnings with Clang 8

The attributes were placed incorrectly -- they need to be after the
"struct" keyword, not before.

Modified:
    libcxx/trunk/include/__node_handle
    libcxx/trunk/include/experimental/functional

Modified: libcxx/trunk/include/__node_handle
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/include/__node_handle?rev=355006&r1=355005&r2=355006&view=diff
==============================================================================
--- libcxx/trunk/include/__node_handle (original)
+++ libcxx/trunk/include/__node_handle Wed Feb 27 09:33:25 2019
@@ -193,8 +193,7 @@ using __map_node_handle =
     __basic_node_handle< _NodeType, _Alloc, __map_node_handle_specifics>;
 
 template <class _Iterator, class _NodeType>
-_LIBCPP_TEMPLATE_VIS
-struct __insert_return_type
+struct _LIBCPP_TEMPLATE_VIS __insert_return_type
 {
     _Iterator position;
     bool inserted;

Modified: libcxx/trunk/include/experimental/functional
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/include/experimental/functional?rev=355006&r1=355005&r2=355006&view=diff
==============================================================================
--- libcxx/trunk/include/experimental/functional (original)
+++ libcxx/trunk/include/experimental/functional Wed Feb 27 09:33:25 2019
@@ -109,8 +109,7 @@ _LIBCPP_BEGIN_NAMESPACE_LFTS
 #if _LIBCPP_STD_VER > 11
 // default searcher
 template<class _ForwardIterator, class _BinaryPredicate = equal_to<>>
-_LIBCPP_TYPE_VIS
-class default_searcher {
+class _LIBCPP_TYPE_VIS default_searcher {
 public:
     _LIBCPP_INLINE_VISIBILITY
     default_searcher(_ForwardIterator __f, _ForwardIterator __l, 
@@ -208,8 +207,7 @@ public:
 template <class _RandomAccessIterator1, 
           class _Hash = hash<typename iterator_traits<_RandomAccessIterator1>::value_type>, 
           class _BinaryPredicate = equal_to<>>
-_LIBCPP_TYPE_VIS
-class boyer_moore_searcher {
+class _LIBCPP_TYPE_VIS boyer_moore_searcher {
 private:
     typedef typename std::iterator_traits<_RandomAccessIterator1>::difference_type difference_type;
     typedef typename std::iterator_traits<_RandomAccessIterator1>::value_type      value_type;
@@ -360,8 +358,7 @@ make_boyer_moore_searcher( _RandomAccess
 template <class _RandomAccessIterator1, 
           class _Hash = hash<typename iterator_traits<_RandomAccessIterator1>::value_type>, 
           class _BinaryPredicate = equal_to<>>
-_LIBCPP_TYPE_VIS
-class boyer_moore_horspool_searcher {
+class _LIBCPP_TYPE_VIS boyer_moore_horspool_searcher {
 private:
     typedef typename std::iterator_traits<_RandomAccessIterator1>::difference_type difference_type;
     typedef typename std::iterator_traits<_RandomAccessIterator1>::value_type      value_type;




More information about the libcxx-commits mailing list