[libcxx-commits] [PATCH] D58425: Fix the build with gcc 8.x when `-Wredundant-decls` is passed

[Enji Cooper via Phabricator via libcxx-commits]

ngie added a comment.

In D58425#1403596 <https://reviews.llvm.org/D58425#1403596>, @EricWF wrote:

> These aren't definitions. They're declarations.


You're correct. I meant declaration, not definition.

> And the warning or broken. We should turn it off not fix it

Unfortunately, things like these aren't necessarily within the control of the llvm project. FreeBSD (for instance) uses its own make infrastructure/flags. In order to catch issues like this (which are valid elsewhere in code) we enable this warning.

Not being able to compile with this warning on gcc is very unfortunate and means we lose out on potentially good coverage/signal.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58425/new/

https://reviews.llvm.org/D58425