[libcxx-commits] [PATCH] D58425: Fix the build with gcc 8.x when `-Wredundant-decls` is passed

Enji Cooper via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Feb 19 23:19:17 PST 2019


ngie added a comment.

In D58425#1403591 <https://reviews.llvm.org/D58425#1403591>, @EricWF wrote:

> but this isn't redundant... as evidenced by the fact there is green in this patch .


There are many instances that I've run into where clang doesn't have issues with redundant definitions, compared to gcc. gcc whines if you define things multiple times, even if the definitions are the same :(.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58425/new/

https://reviews.llvm.org/D58425





More information about the libcxx-commits mailing list