[libcxx-commits] [PATCH] D58203: [libc++] Inline stdexcept constructors, destructors, and assignment operators when using MSVC ABI

Tue Feb 19 16:46:33 PST 2019

thomasanderson added a comment.

In D58203#1403211 <https://reviews.llvm.org/D58203#1403211>, @thakis wrote:

> But D57425 <https://reviews.llvm.org/D57425> landed and this one didn't :-) Is the plan to land this and revert the other one then?

No revert necessary.  It was broken initially, then D57425 <https://reviews.llvm.org/D57425> added a partial fix, now this CL adds a full fix.

At the time I wrote D57425 <https://reviews.llvm.org/D57425>, there was just a duplicate symbol error.  But then a change landed in lld that revealed a different linker error which this CL now fixes.

> It sounded to me like our libc++/win bot is currently happy, what does this change do that the other one misses?

The Windows bots will not be happy without this change (or this other change https://github.com/googlei18n/libaddressinput/pull/172).  I rolled libc++ into Chrome today because I know it's going to be a couple days still before all dependencies get updated, and I wanted to make sure there were no libc++-related issues in the roll in the meantime.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58203/new/

https://reviews.llvm.org/D58203