[libcxx-commits] [libcxxabi] r354284 - [libcxxabi][CMake] Drop unused HandleOutOfTreeLLVM include

Petr Hosek via libcxx-commits libcxx-commits at lists.llvm.org
Mon Feb 18 12:58:06 PST 2019


Author: phosek
Date: Mon Feb 18 12:58:06 2019
New Revision: 354284

URL: http://llvm.org/viewvc/llvm-project?rev=354284&view=rev
Log:
[libcxxabi][CMake] Drop unused HandleOutOfTreeLLVM include

This include doesn't seem to be needed for the standalone build (it's
not being used by libc++ build either), but introduces unnecessary
dependency because HandleOutOfTreeLLVM performs checks that require
a working C++ library. We shouldn't require a working C++ library to
build libc++abi or libc++ (it's what we're building after all).

Differential Revision: https://reviews.llvm.org/D58333

Modified:
    libcxxabi/trunk/cmake/Modules/HandleOutOfTreeLLVM.cmake

Modified: libcxxabi/trunk/cmake/Modules/HandleOutOfTreeLLVM.cmake
URL: http://llvm.org/viewvc/llvm-project/libcxxabi/trunk/cmake/Modules/HandleOutOfTreeLLVM.cmake?rev=354284&r1=354283&r2=354284&view=diff
==============================================================================
--- libcxxabi/trunk/cmake/Modules/HandleOutOfTreeLLVM.cmake (original)
+++ libcxxabi/trunk/cmake/Modules/HandleOutOfTreeLLVM.cmake Mon Feb 18 12:58:06 2019
@@ -93,10 +93,7 @@ macro(configure_out_of_tree_llvm)
     endif()
   endif()
   if (LLVM_FOUND)
-    # Enable warnings, otherwise -w gets added to the cflags by HandleLLVMOptions.
-    set(LLVM_ENABLE_WARNINGS ON)
     include(AddLLVM OPTIONAL)
-    include(HandleLLVMOptions OPTIONAL)
   endif()
 
   # LLVM Options --------------------------------------------------------------




More information about the libcxx-commits mailing list