[libcxx-commits] [PATCH] D58333: [libcxxabi][CMake] Drop unused HandleOutOfTreeLLVM include

Sun Feb 17 23:59:36 PST 2019

Hahnfeld added a comment.

In D58333#1400699 <https://reviews.llvm.org/D58333#1400699>, @phosek wrote:

> This is an alternative to D58331 <https://reviews.llvm.org/D58331> which is an attempt at resolving the breakage introduced in D58013 <https://reviews.llvm.org/D58013>. I think this is a better solution than D58331 <https://reviews.llvm.org/D58331>.

I also think that this one is better than D58331 <https://reviews.llvm.org/D58331>, for the reasons stated in the summary.

> Do you know if there's any reason why `HandleLLVMOptions` was included here?

`HandleLLVMOptions` seems to setup quite a few things, but I think most of them don't apply for `libc++abi` and `libc++` (like LTO, assertions, `-std=c++11`). From looking over the code I guess that warnings and `LLVM_USE_LINKER` could be relevant?

Repository:
  rCXXA libc++abi

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58333/new/

https://reviews.llvm.org/D58333