[libcxx-commits] [PATCH] D58333: [libcxxabi][CMake] Drop unused HandleOutOfTreeLLVM include

[Petr Hosek via Phabricator via libcxx-commits]

phosek created this revision.
phosek added reviewers: ldionne, EricWF.
Herald added subscribers: libcxx-commits, christof, mgorny.

This include doesn't seem to be needed for the standalone build (it's
not being used by libc++ build either), but introduces unnecessary
dependency because HandleOutOfTreeLLVM performs checks that require
a working C++ library. We shouldn't require a working C++ library to
build libc++abi or libc++ (it's what we're building after all).


Repository:
  rCXXA libc++abi

https://reviews.llvm.org/D58333

Files:
  libcxxabi/cmake/Modules/HandleOutOfTreeLLVM.cmake


Index: libcxxabi/cmake/Modules/HandleOutOfTreeLLVM.cmake
===================================================================
--- libcxxabi/cmake/Modules/HandleOutOfTreeLLVM.cmake
+++ libcxxabi/cmake/Modules/HandleOutOfTreeLLVM.cmake
@@ -93,10 +93,7 @@
     endif()
   endif()
   if (LLVM_FOUND)
-    # Enable warnings, otherwise -w gets added to the cflags by HandleLLVMOptions.
-    set(LLVM_ENABLE_WARNINGS ON)
     include(AddLLVM OPTIONAL)
-    include(HandleLLVMOptions OPTIONAL)
   endif()
 
   # LLVM Options --------------------------------------------------------------


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58333.187178.patch
Type: text/x-patch
Size: 579 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20190217/1b5d4a53/attachment-0001.bin>