[libcxx-commits] [PATCH] D58201: Make std::memory_order an enum class (P0439R0)

[JF Bastien via Phabricator via libcxx-commits]

jfb added a comment.

Two small comments, LGTM otherwise (but would like one of the libc++ maintainers to sign off too).



================
Comment at: include/atomic:33
     memory_order_seq_cst   // store-release load-acquire
 } memory_order;
 
----------------
I'm not a fan of the huge comment at the top of files, but I assume you'll need to update it.


================
Comment at: test/std/atomics/atomics.order/memory_order_new.pass.cpp:28
+    assert(static_cast<int>(std::memory_order_acq_rel) == 4);
+    assert(static_cast<int>(std::memory_order_seq_cst) == 5);
+
----------------
This is redundant with the pre-existing test, I would drop it (and keep only lines 16-21).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58201/new/

https://reviews.llvm.org/D58201