[libcxx-commits] [PATCH] D58203: [libc++] Inline stdexcept constructors, destructors, and assignment operators when using MSVC ABI

[Tom Anderson via Phabricator via libcxx-commits]

thomasanderson created this revision.
thomasanderson added reviewers: libcxx-commits, EricWF, thakis, pcc.
Herald added subscribers: jdoerfert, ldionne.

MSVC doesn't provide definitions of functions like
std::logic_error::logic_error(const char*), so they are implicitly generated by
the compiler as inline functions.  The inline-ness in the libc++ implementations
need to match those of MSVC, otherwise we get an ODR violation leading to a
duplicate symbol error when trying to link.


Repository:
  rCXX libc++

https://reviews.llvm.org/D58203

Files:
  include/__config
  include/stdexcept
  src/include/refstring.h
  src/stdexcept.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58203.186722.patch
Type: text/x-patch
Size: 6760 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20190213/eb6dd83b/attachment.bin>