[libcxx-commits] [PATCH] D57403: Extending make_shared to Support Arrays (Partially) - P0674R1

Wed Feb 13 11:58:19 PST 2019

zoecarver marked an inline comment as done.
zoecarver added a comment.

Thanks for the edits, I will fix them now.

================
Comment at: include/memory:4717
+shared_ptr<_Tp>
 make_shared(_Args&& ...__args)
 {
----------------
ldionne wrote:
> You'll need other overloads as outlined in http://wg21.link/p0674. Please add them in this review, otherwise it's too difficult to tell whether the paper is being implemented correctly across reviews.
Fair enough, I will implement those in this review then. 

@ldionne I am having [[ https://gist.github.com/zoecarver/94092aabab2f07d090bbf95a3c78da5e#file-memory-cpp-L33 | trouble with how to implement arrays with unknown length, could you take a look ]]?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57403/new/

https://reviews.llvm.org/D57403