[libcxx-commits] [PATCH] D56913: decoupling Freestanding atomic<T> from libatomic.a

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM, with some de-duplication suggested. I'm not an atomic wrangler, though, so I'd feel more comfortable if someone like @jfb could quickly double-check the implementation of the atomic operations.



================
Comment at: libcxx/include/atomic:1198
+_LIBCPP_INLINE_VISIBILITY 
+bool __cxx_atomic_compare_exchange_weak(volatile __cxx_atomic_lock_impl<_Tp>* __a, 
+                                        _Tp* __expected, _Tp __value, memory_order, memory_order) {
----------------
`__cxx_atomic_compare_exchange_weak` and `__cxx_atomic_compare_exchange_strong` seem the same. Should one just forward to the other?


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56913/new/

https://reviews.llvm.org/D56913