[libcxx-commits] [PATCH] D49587: [CMake] Support exporting runtimes using the CMake export

[Shoaib Meenai via Phabricator via libcxx-commits]

smeenai added inline comments.
Herald added a project: LLVM.


================
Comment at: libcxx/lib/CMakeLists.txt:101
   elseif (LIBCXXABI_ENABLE_STATIC_UNWINDER AND (TARGET unwind_static OR HAVE_LIBUNWIND))
-    add_interface_library(unwind_static)
+    if (NOT LIBCXXABI_ENABLE_STATIC_UNWINDER)
+      add_interface_library(unwind_static)
----------------
Seems like an unrelated change? I can see how it was exposed by adding the exported target support, but it still seems like it could go in separately.


================
Comment at: llvm/runtimes/CMakeLists.txt:220
+  get_property(LLVM_RUNTIMES GLOBAL PROPERTY LLVM_RUNTIMES)
+  export(TARGETS ${LLVM_RUNTIMES} FILE ${LLVM_RUNTIMES_FILE})
+
----------------
Why do we need to collect targets manually instead of just using the `export(EXPORT)` signature?


================
Comment at: llvm/runtimes/CMakeLists.txt:223
+  install(EXPORT LLVMRuntimes
+          DESTINATION lib${LLVM_LIBDIR_SUFFIX}/clang/${CLANG_VERSION}/${LLVM_DEFAULT_TARGET_TRIPLE}
+          COMPONENT cmake-exports)
----------------
Is this assuming the per-triple resource directory layout?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D49587/new/

https://reviews.llvm.org/D49587