[libcxx-commits] [PATCH] D58084: [CMake] Avoid passing -rtlib=compiler-rt when using compiler-rt

[Shoaib Meenai via Phabricator via libcxx-commits]

smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.

I think the commit message could be clarified a bit. Something like

  We build libc++ and libc++abi with -nodefaultlibs, so -rtlib=compiler-rt has no
  effect and results in an 'argument unused during compilation' warning which
  breaks the build when using -Werror. We can therefore drop -rtlib=compiler-rt
  without any functional change; note that the actual compiler-rt linking is
  handled by HandleCompilerRT.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58084/new/

https://reviews.llvm.org/D58084