[libcxx-commits] [PATCH] D58021: Win32 does not have popcnt64 function and fix bug with defines in ctz function

[Marshall Clow via Phabricator via libcxx-commits]

mclow.lists requested changes to this revision.
mclow.lists added inline comments.
This revision now requires changes to proceed.


================
Comment at: include/bit:150
   static_assert(sizeof(unsigned long long) == 8, "");
+#if defined(_M_IX86)
+  // Win32 doesn't have __popcnt64 so emulate it with two 32 bit calls.
----------------
We like our own defines in our files; we try to avoid using things like `_M_IX86` (what does that even mean?)

If we need a new macro that says "We are a 32 bit windows environment", then we should define one.




Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58021/new/

https://reviews.llvm.org/D58021