[libcxx-commits] [PATCH] D58021: Win32 does not have popcnt64 function and fix bug with defines in ctz function

[Eric Fiselier via Phabricator via libcxx-commits]

EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.

LGTM other than inline nits.



================
Comment at: include/bit:92
+#if defined(_LIBCPP_HAS_BITSCAN64) && \
     (defined(_M_AMD64) || defined(__x86_64__))
   if (_BitScanForward64(&__where, __x))
----------------
This check seems redundant since `_LIBCPP_HAS_BITSCAN` is defined by those very same conditions.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58021/new/

https://reviews.llvm.org/D58021