[libcxx-commits] [PATCH] D58023: MSVC does not provide constexpr for typeid and typeid is probably not constexpr

[Danila Kutenin via Phabricator via libcxx-commits]

danlark created this revision.
danlark added reviewers: EricWF, mclow.lists.
Herald added a subscriber: ldionne.

Actually, there is nothing about `constexpr` qualifier for `typeid` operator in the standard and MSVC is probably correct in this case.

I can be wrong and if you convince me that `typeid` should be constexpr, I would discard this review and submit a bug to the Microsoft compiler team


Repository:
  rCXX libc++

https://reviews.llvm.org/D58023

Files:
  functional


Index: functional
===================================================================
--- functional
+++ functional
@@ -1901,12 +1901,12 @@
     _LIBCPP_INLINE_VISIBILITY
     static const __policy* __create_empty()
     {
-        static const _LIBCPP_CONSTEXPR __policy __policy_ = {nullptr, nullptr,
-                                                             true,
+        static const __policy __policy_ = {nullptr, nullptr,
+                                           true,
 #ifndef _LIBCPP_NO_RTTI
-                                                             &typeid(void)
+                                           &typeid(void)
 #else
-                                                             nullptr
+                                           nullptr
 #endif
         };
         return &__policy_;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58023.186181.patch
Type: text/x-patch
Size: 819 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20190211/96929df6/attachment.bin>