[libcxx-commits] [PATCH] D58011: Fix -fsanitize=vptr badness in <__debug>

[Eric Fiselier via Phabricator via libcxx-commits]

EricWF created this revision.
EricWF added a reviewer: ldionne.
EricWF added a project: libc++.
Herald added a subscriber: christof.
Herald added a reviewer: serge-sans-paille.

This patch fixes a lifetime bug when inserting a new container into the debug database. It is
diagnosed by UBSAN when debug mode is enabled. This patch corrects how nodes are constructed
during insertion.

The fix requires unconditionally breaking the debug mode ABI. Users should not expect ABI
stability from debug mode.


Repository:
  rCXX libc++

https://reviews.llvm.org/D58011

Files:
  include/__debug
  lib/abi/CHANGELOG.TXT
  lib/abi/x86_64-apple-darwin.v1.abilist
  lib/abi/x86_64-apple-darwin.v2.abilist
  lib/abi/x86_64-unknown-linux-gnu.v1.abilist
  src/debug.cpp
  test/libcxx/debug/containers/db_sequence_container_iterators.pass.cpp
  utils/libcxx/test/config.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58011.186143.patch
Type: text/x-patch
Size: 7191 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20190210/b16d1d12/attachment-0001.bin>