[libcxx-commits] [libcxx] r353215 - [libc++] Fix XFAILs when exceptions are disabled

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Tue Feb 5 12:55:24 PST 2019


Author: ldionne
Date: Tue Feb  5 12:55:23 2019
New Revision: 353215

URL: http://llvm.org/viewvc/llvm-project?rev=353215&view=rev
Log:
[libc++] Fix XFAILs when exceptions are disabled

It turns out that I un-XFAILed too many tests in r353210: some tests
actually fail whether exceptions are enabled or not because they use
types that are marked as unavailable even when exceptions are disabled.

Modified:
    libcxx/trunk/test/std/utilities/optional/optional.bad_optional_access/default.pass.cpp
    libcxx/trunk/test/std/utilities/optional/optional.bad_optional_access/derive.pass.cpp
    libcxx/trunk/test/std/utilities/variant/variant.bad_variant_access/bad_variant_access.pass.cpp

Modified: libcxx/trunk/test/std/utilities/optional/optional.bad_optional_access/default.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/utilities/optional/optional.bad_optional_access/default.pass.cpp?rev=353215&r1=353214&r2=353215&view=diff
==============================================================================
--- libcxx/trunk/test/std/utilities/optional/optional.bad_optional_access/default.pass.cpp (original)
+++ libcxx/trunk/test/std/utilities/optional/optional.bad_optional_access/default.pass.cpp Tue Feb  5 12:55:23 2019
@@ -8,7 +8,7 @@
 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
 
-// XFAIL: dylib-has-no-bad_optional_access && !libcpp-no-exceptions
+// XFAIL: dylib-has-no-bad_optional_access
 
 // <optional>
 

Modified: libcxx/trunk/test/std/utilities/optional/optional.bad_optional_access/derive.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/utilities/optional/optional.bad_optional_access/derive.pass.cpp?rev=353215&r1=353214&r2=353215&view=diff
==============================================================================
--- libcxx/trunk/test/std/utilities/optional/optional.bad_optional_access/derive.pass.cpp (original)
+++ libcxx/trunk/test/std/utilities/optional/optional.bad_optional_access/derive.pass.cpp Tue Feb  5 12:55:23 2019
@@ -7,7 +7,7 @@
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
-// XFAIL: dylib-has-no-bad_optional_access && !libcpp-no-exceptions
+// XFAIL: dylib-has-no-bad_optional_access
 
 // <optional>
 

Modified: libcxx/trunk/test/std/utilities/variant/variant.bad_variant_access/bad_variant_access.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/utilities/variant/variant.bad_variant_access/bad_variant_access.pass.cpp?rev=353215&r1=353214&r2=353215&view=diff
==============================================================================
--- libcxx/trunk/test/std/utilities/variant/variant.bad_variant_access/bad_variant_access.pass.cpp (original)
+++ libcxx/trunk/test/std/utilities/variant/variant.bad_variant_access/bad_variant_access.pass.cpp Tue Feb  5 12:55:23 2019
@@ -9,7 +9,7 @@
 
 // UNSUPPORTED: c++98, c++03, c++11, c++14
 
-// XFAIL: dylib-has-no-bad_variant_access && !libcpp-no-exceptions
+// XFAIL: dylib-has-no-bad_variant_access
 
 
 // <variant>




More information about the libcxx-commits mailing list