[libcxx-commits] [PATCH] D57734: priority_queue::replace_top(x)

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

I think this functionality might be interesting, but trying to get this into libc++ before it is standardized is definitely putting the cart before the horse. I understand that putting the patch here may make it easier for people to apply it to their local copy of libc++. Hopefully not many people think of themselves as vendors and maintain their own libc++ :-).



================
Comment at: include/queue:549
+    void replace_top(const value_type& __v);
+#ifndef _LIBCPP_CXX03_LANG
+    _LIBCPP_INLINE_VISIBILITY
----------------
This should instead be `#if _LIBCPP_STD_VER > 23`, or whatever standard version you target with this feature.


================
Comment at: test/libcxx/containers/container.adaptors/priority.queue/priqueue.members/replace_top_rvalue.pass.cpp:9
+
+// UNSUPPORTED: c++98, c++03
+
----------------
This should be `UNSUPPORTED` until the standard version where the feature is being added.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57734/new/

https://reviews.llvm.org/D57734