[libcxx-commits] [PATCH] D57761: [libc++] Avoid UB in the no-exceptions mode in a few places

[JF Bastien via Phabricator via libcxx-commits]

jfb added a comment.

In D57761#1385562 <https://reviews.llvm.org/D57761#1385562>, @jfb wrote:

> I'm wondering if, as a follow-up, the XFAIL tests that validate the behavior for exceptions should instead:
>
> - Not XFAIL
> - Install a SIGABORT handler, and call `exit(0)` or something
> - Instead of `catch`, call `exit(1)` because we expected the abort handler to be called.
>
>   That type of testing will find any missing fixes from this patch (and prevent regressions).


To clarify my logic based on a private chat with @mclow.lists: Louis is changing code that's clearly doing the wrong thing, yet no tests are being changed. Louis' change is correct, therefore the tests were inadequate.

I don't think this patch really needs to fix the tests, but I think the tests need a bit of love for this odd use case.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57761/new/

https://reviews.llvm.org/D57761