[libcxx-commits] [PATCH] D57761: [libc++] Avoid UB in the no-exceptions mode in a few places
JF Bastien via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Feb 5 10:30:39 PST 2019
jfb added a comment.
I'm wondering if, as a follow-up, the XFAIL tests that validate the behavior for exceptions should instead:
- Not XFAIL
- Install a SIGABORT handler, and call `exit(0)` or something
- Instead of `catch`, call `exit(1)` because we expected the abort handler to be called.
That type of testing will find any missing fixes from this patch (and prevent regressions).
Repository:
rCXX libc++
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57761/new/
https://reviews.llvm.org/D57761
More information about the libcxx-commits
mailing list