[libcxx-commits] [PATCH] D57624: Support tests in freestanding

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Feb 4 21:31:03 PST 2019


Quuxplusone added a comment.

Hi @jfb, this commit broke /utils/generate_feature_test_macro_components.py in the libc++ repo by replacing **two** curly braces with **one** curly brace:

  diff --git a/utils/generate_feature_test_macro_components.py b/utils/generate_feature_test_macro_components.py
  index 2bd80a8..d923208 100755
  --- a/utils/generate_feature_test_macro_components.py
  +++ b/utils/generate_feature_test_macro_components.py
  @@ -865,7 +865,7 @@ def produce_tests():
   
   #endif // TEST_STD_VER > 17
   
  -int main() {{}}
  +int main(int, char**) { return 0; }
   """.format(script_name=script_name,
              header=h,
              test_tags=test_tags,

The correct line here would have been

  int main(int, char**) {{ return 0; }}

Do you think you could push that fix? Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57624/new/

https://reviews.llvm.org/D57624





More information about the libcxx-commits mailing list