[libcxx-commits] [PATCH] D57734: priority_queue::replace_top(x)

[Marshall Clow via Phabricator via libcxx-commits]

mclow.lists added a comment.

Arthur - I'm sorry to say that this will go nowhere.
You're introducing non-reserved identifiers into libc++, which can cause legal code to break.

For example:

  #define poke_heap 9+7
  #include <queue>

Same with `replace_top`
Users are prohibited from doing this for names that is mentioned in the standard,  but neither of those fall into that category.
that's why `__sift_down` is named how it is, for example -  users can't define them as a macro.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57734/new/

https://reviews.llvm.org/D57734