[libcxx-commits] [PATCH] D57403: Extending make_shared to Support Arrays (Partially) - P0674R1

Zoe Carver via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Feb 4 21:02:12 PST 2019


zoecarver updated this revision to Diff 185231.
zoecarver added a comment.

I added a test to make sure the right number of constructors/destructors were called.

I could not get `ASSERT_SAME_TYPE` working, I looked at some examples but eventually gave up. From the snippet I gave can you see what is wrong?

Thanks again for helping me through this process :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57403/new/

https://reviews.llvm.org/D57403

Files:
  include/memory
  test/libcxx/memory/shared_ptr_array.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57403.185231.patch
Type: text/x-patch
Size: 3285 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20190205/e3262f3e/attachment-0001.bin>


More information about the libcxx-commits mailing list