[libcxx-commits] [PATCH] D57624: Support tests in freestanding

Ben Craig via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Feb 4 11:29:02 PST 2019


bcraig added a comment.

>> I like this too, however I don't know how this interacts with tests like `test/libcxx/language.support/support.dynamic/new_faligned_allocation.sh.cpp` that specify the build command-line explicitly:
>> 
>>   // RUN: %build -faligned-allocation
>> 
>> 
>> We'd make sure that `%build` links in the additional entry point?
> 
> Agreed that seems problematic, but I think we can fix it after this patch lands. :)

I didn't run into any of these for the freestanding things I was working on.  Admittedly, I skipped the things that I want removed, and that includes any allocating form of new and delete.  It was also in a snapshot of libcxx from a bit more than a year ago.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57624/new/

https://reviews.llvm.org/D57624





More information about the libcxx-commits mailing list