[libcxx-commits] [PATCH] D57624: Support tests in freestanding

[JF Bastien via Phabricator via libcxx-commits]

jfb added a comment.



>> - I strongly believe that different freestanding systems will have different setup/teardown requirements that we should not try to address in the libc++ test suite, and so @jfb 's suggestion of having a different entry point that calls `main(int, char**)` is a good way to go.

OK I updated the patch with this.

> I like this too, however I don't know how this interacts with tests like `test/libcxx/language.support/support.dynamic/new_faligned_allocation.sh.cpp` that specify the build command-line explicitly:
> 
>   // RUN: %build -faligned-allocation
> 
> 
> We'd make sure that `%build` links in the additional entry point?

Agreed that seems problematic, but I think we can fix it after this patch lands. :)


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57624/new/

https://reviews.llvm.org/D57624