[libcxx-commits] [PATCH] D57624: Support tests in freestanding

Marshall Clow via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Feb 4 09:56:35 PST 2019


mclow.lists added a comment.

My take on this is

- adding `return 0` to the end of all the tests, and changing the signature of `main` to always be `int main(int, char**)` is a simple mechanical transformation, and once we decide that we want to do that, doesn't really need review

- I strongly believe that different freestanding systems will have different setup/teardown requirements that we should not try to address in the libc++ test suite, and so @jfb 's suggestion of having a different entry point that calls `main(int, char**)` is a good way to go.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57624/new/

https://reviews.llvm.org/D57624





More information about the libcxx-commits mailing list