[libcxx-commits] [PATCH] D69893: libunwind: Evaluating DWARF operation DW_OP_pick is broken

Wed Dec 18 12:24:51 PST 2019

steven_wu accepted this revision.
steven_wu added a comment.

In D69893#1786222 <https://reviews.llvm.org/D69893#1786222>, @kamleshbhalui wrote:

> In D69893#1786202 <https://reviews.llvm.org/D69893#1786202>, @steven_wu wrote:
>
> > The fix LGTM. Do you have a reproducer that can be used as a test case? We should really add more tests for libunwind.
>
>
> I currently do not have a reproducer test case for this.

Ok. We will need to come back dealing with test coverage in the future. I can commit it for you.

Repository:
  rUNW libunwind

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69893/new/

https://reviews.llvm.org/D69893