[libcxx-commits] [PATCH] D69466: Guard against overflow in span::subspan

Marshall Clow via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Dec 16 08:34:16 PST 2019


mclow.lists added a comment.

There's at least three things going on in this patch; and that makes it harder to review:

- Rename all the `index_type`s to `size_type`.
- Add `static_assert` to several cases
- Guard against overflow in span::subspan (ostensibly the purpose of this patch).

In the future, this should be three patches.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69466/new/

https://reviews.llvm.org/D69466





More information about the libcxx-commits mailing list