[libcxx-commits] [PATCH] D62454: SFINAE on pair/tuple assignment operators 2729

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver marked an inline comment as done.
zoecarver added inline comments.


================
Comment at: test/std/utilities/utility/pairs/pairs.pair/assign_rv_pair.pass.cpp:25
+struct NonMoveAssignable {
+  NonMoveAssignable& operator=(NonMoveAssignable&&) = delete;
 };
----------------
ldionne wrote:
> You should be able to add this to make it copy-assignable:
> 
> ```
> NonMoveAssignable& operator=(NonMoveAssignable const&) = default;
> ```
> 
Hmm you're right but that unfortunatly fails the test `!std::is_move_assignable<std::pair<int, NonMoveAssignable>>::value`. I'll look into fixing it. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62454/new/

https://reviews.llvm.org/D62454