[libcxx-commits] [PATCH] D71117: Reland "Enable `-funwind-tables` flag when building libunwind"

[Sergej Jaskiewicz via Phabricator via libcxx-commits]

broadwaylamb created this revision.
broadwaylamb added a reviewer: mstorsjo.
Herald added subscribers: libcxx-commits, christof, mgorny.
Herald added a reviewer: jfb.
Herald added a project: libc++.

Relands https://reviews.llvm.org/D70815.

The original commit set `CMAKE_TRY_COMPILE_TARGET_TYPE` to
`STATIC_LIBRARY` globally in libunwind/CMakeLists.txt, which effectively
disabled the linking step in CMake checks.

This broke some builds (see 938c70b86c7d2165f8c28d5700e9c1ac1263307e <https://reviews.llvm.org/rG938c70b86c7d2165f8c28d5700e9c1ac1263307e>).

Here we set CMAKE_TRY_COMPILE_TARGET_TYPE to
STATIC_LIBRARY only when checking for presence of the `-funwind-tables`
flag, and then set it back to the original value so it doesn't affect
other checks.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D71117

Files:
  libunwind/CMakeLists.txt
  libunwind/cmake/config-ix.cmake
  libunwind/test/CMakeLists.txt
  libunwind/test/libunwind/test/config.py
  libunwind/test/lit.site.cfg.in
  libunwind/test/signal_frame.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D71117.232550.patch
Type: text/x-patch
Size: 5213 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20191206/51761885/attachment-0001.bin>