[libcxx-commits] [PATCH] D70815: Enable `-funwind-tables` flag when building libunwind
Martin Storsjö via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Dec 3 23:39:52 PST 2019
mstorsjo added a comment.
I went ahead and reverted this, as it broke how some cmake tests within libunwind work.
As this disables linking, it falsely makes any test succeed that depends on linking, and there's a few such tests in cmake/config-ix.cmake (`check_library_exists(c fopen "" LIBUNWIND_HAS_C_LIB)`, `check_library_exists(dl dladdr "" LIBUNWIND_HAS_DL_LIB)`, etc).
Therefore, `set(CMAKE_TRY_COMPILE_TARGET_TYPE STATIC_LIBRARY)` has to be carefully placed at a spot where all such tests that does require linking already has been completed.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits