[libcxx-commits] [PATCH] D62868: [libc++] Always build with -fvisibility=hidden

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D62868#1648991 <https://reviews.llvm.org/D62868#1648991>, @peter.smith wrote:

> Apologies for the late notice, we've just moved one our builders http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-armv7-linux-noexceptions to use gcc rather than clang and we've just picked up some test failures due to this change. In summary when compiling libc++ with GCC the shared object defines a symbol as hidden that clang does not which is causing test failures due to linker errors. I've put the details in https://bugs.llvm.org/show_bug.cgi?id=43140 . It looks like the failure was first seen on http://lab.llvm.org:8011/builders/libcxx-libcxxabi-x86_64-linux-ubuntu-gcc5-cxx11/builds/345 (not run by us).


Quick update for watchers:

The bug mentioned by Peter has been fixed now, but I'm looking into other link errors when using GCC (because there's more).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62868/new/

https://reviews.llvm.org/D62868