[libcxx-commits] [libcxx] r370240 - [libc++] Fix visibility of __vector_base_common on GCC

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Wed Aug 28 11:10:39 PDT 2019


Author: ldionne
Date: Wed Aug 28 11:10:39 2019
New Revision: 370240

URL: http://llvm.org/viewvc/llvm-project?rev=370240&view=rev
Log:
[libc++] Fix visibility of __vector_base_common on GCC

Since we build the library with -fvisibility=hidden, the shared object
wouldn't contain __vector_base_common<true>::__throw_length_error()
and __vector_base_common<true>::__throw_out_of_range(), leading to
link errors. This only happened on GCC for some reason.

https://llvm.org/PR43140

Modified:
    libcxx/trunk/include/vector

Modified: libcxx/trunk/include/vector
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/include/vector?rev=370240&r1=370239&r2=370240&view=diff
==============================================================================
--- libcxx/trunk/include/vector (original)
+++ libcxx/trunk/include/vector Wed Aug 28 11:10:39 2019
@@ -297,7 +297,7 @@ _LIBCPP_PUSH_MACROS
 _LIBCPP_BEGIN_NAMESPACE_STD
 
 template <bool>
-class __vector_base_common
+class _LIBCPP_TEMPLATE_VIS __vector_base_common
 {
 protected:
     _LIBCPP_INLINE_VISIBILITY __vector_base_common() {}




More information about the libcxx-commits mailing list