[libcxx-commits] [PATCH] D62889: rvalue stream operators (1203 and 2534)

[Marshall Clow via Phabricator via libcxx-commits]

mclow.lists added inline comments.


================
Comment at: test/std/input.output/iostream.format/input.streams/istream.rvalue/ios_base_operator_overload_resolution.fail.cpp:31
+    std::istringstream is;
+    std::move(is) >> A{}; // expected-error-re {{invalid operands to binary expression {{.*}}}}
+
----------------
Instead of `std::move(is)`, you could just use `std::istringstream()`


================
Comment at: test/std/input.output/iostream.format/input.streams/istream.rvalue/perfect_forwarding.pass.cpp:41
+        std::istringstream ss;
+        B b;
+        std::move(ss) >> b;
----------------
Why `A` and `B` here? What's the point of having two different types?
And do `A` and `B` have stream insertion operations?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62889/new/

https://reviews.llvm.org/D62889