[libcxx-commits] [PATCH] D65667: [libcxx] Avoid destructor call for error_category singletons
Eric Fiselier via libcxx-commits
libcxx-commits at lists.llvm.org
Fri Aug 23 15:55:49 PDT 2019
Have you looked at the codegen clang produces for my suggestion?
On Fri., Aug. 23, 2019, 3:01 p.m. Hubert Tong via Phabricator, <
reviews at reviews.llvm.org> wrote:
> hubert.reinterpretcast added a comment.
> In D65667#1643305 <https://reviews.llvm.org/D65667#1643305>, @EricWF
> > That doesn't need to happen now. But I want to see these changed to be
> global statics not function local. At least that way we omit the guards
> entirely. and accessing the variable becomes a single instruction.
> This goes back to the "paying for something you don't use" with regards to
> the up-front library loading cost. If people are actually agreed on this
> course of action, then we can create that version of the patch, but it does
> not seem clear to me.
> CHANGES SINCE LAST ACTION
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the libcxx-commits