[libcxx-commits] [PATCH] D66594: libcxx: Make gen_link_script.py only print contents in --dryrun mode

Phabricator via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Aug 23 06:39:53 PDT 2019


This revision was automatically updated to reflect the committed changes.
Closed by commit rL369757: libcxx: Make gen_link_script.py print contents only in --dryrun mode (authored by nico, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Changed prior to commit:
  https://reviews.llvm.org/D66594?vs=216618&id=216827#toc

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66594/new/

https://reviews.llvm.org/D66594

Files:
  libcxx/trunk/utils/gen_link_script.py


Index: libcxx/trunk/utils/gen_link_script.py
===================================================================
--- libcxx/trunk/utils/gen_link_script.py
+++ libcxx/trunk/utils/gen_link_script.py
@@ -24,7 +24,8 @@
     parser.add_argument("--rename", action="store_true", default=False,
                         help="Rename the output as input so we can replace it")
     parser.add_argument("--input", help="Path to libc++ library", required=True)
-    parser.add_argument("--output", help="Path to libc++ linker script", required=True)
+    parser.add_argument("--output", help="Path to libc++ linker script",
+                        required=True)
     parser.add_argument("libraries", nargs="+",
                         help="List of libraries libc++ depends on")
     args = parser.parse_args()
@@ -37,9 +38,9 @@
 
     # Generate the linker script contents.
     contents = "INPUT(%s)" % ' '.join([libcxx] + public_libs)
-    print("GENERATING SCRIPT: '%s' as file %s" % (contents, args.output))
 
     if args.dryrun:
+        print("GENERATING SCRIPT: '%s' as file %s" % (contents, args.output))
         return 0
 
     # Remove the existing libc++ symlink if it exists.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66594.216827.patch
Type: text/x-patch
Size: 1184 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20190823/1cc2258b/attachment.bin>


More information about the libcxx-commits mailing list