[libcxx-commits] [PATCH] D66594: libcxx: Make gen_link_script.py only print contents in --dryrun mode

[Nico Weber via Phabricator via libcxx-commits]

thakis created this revision.
thakis added a reviewer: EricWF.
Herald added a subscriber: christof.

The build should generally be quiet if there are no errors,
and this script has been around long enough that we can remove
the log output. If we ever need to debug something with this script,
we can put back the logging then.


https://reviews.llvm.org/D66594

Files:
  libcxx/utils/gen_link_script.py


Index: libcxx/utils/gen_link_script.py
===================================================================
--- libcxx/utils/gen_link_script.py
+++ libcxx/utils/gen_link_script.py
@@ -24,7 +24,8 @@
     parser.add_argument("--rename", action="store_true", default=False,
                         help="Rename the output as input so we can replace it")
     parser.add_argument("--input", help="Path to libc++ library", required=True)
-    parser.add_argument("--output", help="Path to libc++ linker script", required=True)
+    parser.add_argument("--output", help="Path to libc++ linker script",
+                        required=True)
     parser.add_argument("libraries", nargs="+",
                         help="List of libraries libc++ depends on")
     args = parser.parse_args()
@@ -37,9 +38,9 @@
 
     # Generate the linker script contents.
     contents = "INPUT(%s)" % ' '.join([libcxx] + public_libs)
-    print("GENERATING SCRIPT: '%s' as file %s" % (contents, args.output))
 
     if args.dryrun:
+        print("GENERATING SCRIPT: '%s' as file %s" % (contents, args.output))
         return 0
 
     # Remove the existing libc++ symlink if it exists.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66594.216618.patch
Type: text/x-patch
Size: 1166 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20190822/fdbc6aac/attachment-0001.bin>