[libcxx-commits] [PATCH] D62451: Regex backreference [1/3] Fixes backreferences for extended grammar.
Zoe Carver via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Sat Aug 17 10:01:32 PDT 2019
zoecarver added inline comments.
Comment at: libcxx/include/regex:3544
+ __first = ++__temp;
Is the intent here that `__first = ++__temp` will be executed regardless of the value of `__val`, or that it will only be executed if `__val` is greater than `1` and less than `9`? If the former, I think you should unindent the statement, as it makes the intent confusing. If the latter, then you need braces around the if statement.
CHANGES SINCE LAST ACTION
More information about the libcxx-commits