[libcxx-commits] [PATCH] D65895: Fix a layering violation in mutex - prep for fixing PR42918

David Spickett via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Aug 15 06:12:02 PDT 2019


DavidSpickett added a comment.

The move of __thread_id to <__threading_support> has caused a build error for us when _LIBCPP_HAS_THREAD_API_EXTERNAL is true

As far as I can tell __thread_id used to only require that _LIBCPP_HAS_NO_THREADS was false, but now it checks that both defines are false. I've been able to fix it locally but in a rather ugly way initially. I thought I'd let you know in case you had an idea of how it should be fixed. (or maybe I'm missing something)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65895/new/

https://reviews.llvm.org/D65895





More information about the libcxx-commits mailing list