[libcxx-commits] [PATCH] D66262: Constrain tuple/unique_ptr move constructors (2899)
Zoe Carver via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Wed Aug 14 17:17:48 PDT 2019
zoecarver marked 3 inline comments as done.
zoecarver added a comment.
It did not appear that `<tuple>` needed to be updated. Correct me if I am wrong.
Comment at: libcxx/include/memory:2479
"rvalue deleter bound to reference");
The indentation is wrong in this section of the file.
Comment at: libcxx/include/memory:2514
+ template<class _Dummy = typename remove_const<typename remove_reference<_Dp>::type>::type>
The issue said to use `is_move_assignable_v<D>` but, that will cause some deleters to break. Thoughts on a better way to resolve this? Or should we make people change how they pass their deleter types?
Comment at: libcxx/include/memory:2540
unique_ptr(unique_ptr const&) = delete;
This is unconditionally added because otherwise this overload may be picked when the other overloads are disabled.
CHANGES SINCE LAST ACTION
More information about the libcxx-commits