[libcxx-commits] [PATCH] D62233: General shared_ptr cleanup

Zoe Carver via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Aug 13 09:08:45 PDT 2019

zoecarver added a comment.

In D62233#1627092 <https://reviews.llvm.org/D62233#1627092>, @ldionne wrote:

> Could you please split this patch into one that removes the variadic stuff, and one that does the rest (so we can look at them separately). I think we can get rid of the variadic stuff because of Clang extensions, but it's not clear to me the rest is worth doing.

@EricWF is going to remove the variadics here. The code I removed here is removing `shared_ptr::make_shared` and `shared_ptr::allocate_shared`. Those two static member functions should not exist and are not part of the standard. Would it be helpful for me to break this patch down further into smaller patches?



More information about the libcxx-commits mailing list