[libcxx-commits] [PATCH] D65900: [libc++] Use [[nodiscard]] for lock_guard, as an extension

[Eric Fiselier via Phabricator via libcxx-commits]

EricWF accepted this revision.
EricWF added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libcxx/include/__config:1016
+   // Standard specifies the constructor as [[nodiscard]]
+#  define _LIBCPP_NODISCARD_CTOR _LIBCPP_NODISCARD
+
----------------
What happens when we apply this attribute to a constructor with a compiler that doesn't yet support it?

Does the warning escape the system header?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65900/new/

https://reviews.llvm.org/D65900