[libcxx-commits] [PATCH] D65895: Fix a layering violation in mutex - prep for fixing PR42918

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Aug 8 11:40:15 PDT 2019


ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

Apart from my comment, this LGTM.



================
Comment at: libcxx/include/thread:242
+    _LIBCPP_INLINE_VISIBILITY
+    void reset() { __id_ = 0; }
+    
----------------
I would rather call this `__reset()` to make it clear it's not part of the public API.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65895/new/

https://reviews.llvm.org/D65895





More information about the libcxx-commits mailing list