[libcxx-commits] [PATCH] D65831: libc++: add `-include` or `/FI` to the interface compile definitions

[Shoaib Meenai via Phabricator via libcxx-commits]

smeenai added a comment.

In D65831#1619712 <https://reviews.llvm.org/D65831#1619712>, @compnerd wrote:

> Hmm, yes, it is for use from the build tree.  I don't see how `INTERFACE_INCLUDE_DIRECTORIES` can do a `-include` though.  It has to be `INTERFACE_COMPILE_OPTIONS` or `INTERFACE_COMPILE_DEFINITIONS`.


Sorry, that was me not thinking properly :D The comment about `BUILD_INTERFACE` stills stands though.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65831/new/

https://reviews.llvm.org/D65831