[libcxx-commits] [PATCH] D65816: [libcxx] Mark unsupported tests under root user

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Aug 6 11:45:48 PDT 2019


ldionne added a comment.

In D65816#1617459 <https://reviews.llvm.org/D65816#1617459>, @twoh wrote:

>




> I admit that this is not a common case, but still, wouldn't it be better to make the tests working under any circumstance?

No, because that means we have to maintain that. In this specific case, support for running the tests under `root` also means that we have to be careful with not messing up your system in irreversible ways in the test suite. And it would mean in theory that we need to add such a testing configuration, otherwise the tests and the annotations will get out of sync and your use case will break again.

We discussed it with other libc++ maintainers and it is our opinion that the use case of running the tests under `sudo` is not something we want to support at the moment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65816/new/

https://reviews.llvm.org/D65816





More information about the libcxx-commits mailing list