[libcxx-commits] [PATCH] D65365: Implement `hh_mm_ss` from P1466R3
Marshall Clow via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Mon Aug 5 21:37:26 PDT 2019
mclow.lists marked an inline comment as done.
mclow.lists added a comment.
The `__pow10` and `__width` routines are only called at compile-time; no run-time code at all.
We have a "power of 10" table in `charconv`, but I don't think that coupling `<chrono>` and `<charconv>` is worth the benefit of removing this small routine.
Comment at: libcxx/include/chrono:2766
+ static constexpr unsigned __width(uint64_t __n, uint64_t __d = 10, unsigned __w = 0)
+ if (__n >= 2 && __d != 0 && __w < 19)
> ldionne wrote:
> > Indentation looks funny (here and elsewhere). Is it just Phab acting up?
> I think this is just phab. It might be that I've got a tab in here.
It was some tabs.
CHANGES SINCE LAST ACTION
More information about the libcxx-commits