[libcxx-commits] [PATCH] D65365: Implement `hh_mm_ss` from P1466R3

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added inline comments.
This revision now requires changes to proceed.


================
Comment at: libcxx/include/chrono:2757
+
+    static constexpr uint64_t __pow10(unsigned __exp)
+    {
----------------
It seems like this shouldn't be reimplemented inside this class, instead we should put this at namespace scope if we don't already have something like that.


================
Comment at: libcxx/include/chrono:2765
+
+    static constexpr unsigned __width(uint64_t __n, uint64_t __d = 10, unsigned __w = 0)
+        {
----------------
Same comment as above regarding duplication.


================
Comment at: libcxx/include/chrono:2766
+    static constexpr unsigned __width(uint64_t __n, uint64_t __d = 10, unsigned __w = 0)
+        {
+        if (__n >= 2 && __d != 0 && __w < 19)
----------------
Indentation looks funny (here and elsewhere). Is it just Phab acting up?


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65365/new/

https://reviews.llvm.org/D65365